Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

em100: init at unstable-2022-05-02-86631c9 #178213

Closed
wants to merge 3 commits into from
Closed

em100: init at unstable-2022-05-02-86631c9 #178213

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2022

Description of changes

The second commit adds a new package for the em100 tool written (mostly) by the coreboot team for the Dediprog EM100Pro SPI Flash Emulator.

The first commit adds myself (amjoseph) to maintainers.nix.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild labels Jun 19, 2022
[1] https://www.dediprog.com/product/EM100Pro-G2
'';
license = licenses.gpl2Plus;
sourceProvenance = [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fill?

Copy link
Author

@ghost ghost Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sourceProvenance=[], sourceProvenance=[lib.sourceTypes.fromSource], and sourceProvenance being missing all mean the same thing.

Yeah, I think that's weird.

I updated the commit to use the more-explicit form sourceProvenance=[lib.sourceTypes.fromSource].

@ghost
Copy link
Author

ghost commented Jul 4, 2022

Force-push is a squash, no other changes.

@ghost
Copy link
Author

ghost commented Jul 4, 2022

Second force-push fixes the version number in the commit message, no other changes.

Adam Joseph and others added 2 commits July 3, 2022 19:43
Co-authored-by: Artturi <Artturin@artturin.com>
@ghost ghost changed the title em100: init at unstable-2022may02-86631c9 em100: init at unstable-2022-05-02-86631c9 Jul 4, 2022
@ghost ghost mentioned this pull request Jul 28, 2022
5 tasks
@ghost ghost closed this Aug 8, 2022
@Artturin Artturin reopened this Aug 9, 2022
@ghost ghost closed this Aug 13, 2022
@ghost ghost deleted the pr/newpackage/em100 branch August 13, 2022 01:23
@Artturin
Copy link
Member

I meant to merge this once the ci was done but I forgot 😅

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant